Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRT] Import parameter check for fclose from wine #5692

Merged
merged 1 commit into from Sep 17, 2023
Merged

Conversation

tkreuzer
Copy link
Contributor

@tkreuzer tkreuzer commented Sep 16, 2023

Fixes advpack_apitest:DelNode crash.

If we properly synced this code, instead of forking it, we wouldn't have this crash.

JIRA issue: CORE-19172

Fixes advpack_apitest:DelNode crash.
@tkreuzer tkreuzer added 3rd party sync Updating 3rd party components, such as Wine and others bugfix For bugfix PRs. labels Sep 16, 2023
@tkreuzer tkreuzer self-assigned this Sep 16, 2023
Copy link
Contributor

@DarkFire01 DarkFire01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only we did indeed :P

@JoachimHenze
Copy link
Contributor

Fix the crash at advpack:DelNode testcase.

Entered debugger on first-chance exception (Exception Code: 0xc0000005) (Page Fault)
Memory at 0x0000000C could not be accessed

kdb:> bt
Eip:
<msvcrt.dll:12a75 (sdk/lib/crt/stdio/file.c:1198 (_lock_file))>
Frames:
<msvcrt.dll:15442 (sdk/lib/crt/stdio/file.c:2785 (fclose))>
<advpack_apitest.exe:12a3 (modules/rostests/apitests/advpack/DelNode.c:428 (func_DelNode))>
<advpack_apitest.exe:1b79 (sdk/include/reactos/wine/test.h:873 (run_test))>
<advpack_apitest.exe:283e (sdk/include/reactos/wine/test.h:930 (main))>
<advpack_apitest.exe:2d9d (sdk/lib/crt/startup/crtexe.c:311 (__tmainCRTStartup))>
<advpack_apitest.exe:2e14 (sdk/lib/crt/startup/crtexe.c:192 (mainCRTStartup))>
<kernel32.dll:11b41 (dll/win32/kernel32/client/proc.c:465 (BaseProcessStartup))>

@tkreuzer tkreuzer merged commit d41a403 into master Sep 17, 2023
73 checks passed
@tkreuzer tkreuzer deleted the fix-fclose branch September 17, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party sync Updating 3rd party components, such as Wine and others bugfix For bugfix PRs.
Projects
None yet
5 participants