Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GITHUB] Update Labeler action to v4 #5753

Closed
wants to merge 1 commit into from
Closed

[GITHUB] Update Labeler action to v4 #5753

wants to merge 1 commit into from

Conversation

sarthakroy2002
Copy link
Contributor

No description provided.

@sarthakroy2002
[GITHUB] Update Labeler action to v4
9300664 
Change-Id: I9281f70bd8576a5bbb5a4e6c430acc931fb402d2
@SergeGautherie
Copy link
Contributor

This should be a good idea.
Review changes at https://github.com/actions/labeler/releases :
for example, 'Make the repo-token input optional. Default is github.token'.

@GeoB99 GeoB99 added this to New PRs in ReactOS PRs via automation Oct 1, 2023
@GeoB99 GeoB99 added the enhancement For PRs with an enhancement/new feature. label Oct 1, 2023
@sarthakroy2002
Copy link
Contributor Author

This should be a good idea. Review changes at https://github.com/actions/labeler/releases : for example, 'Make the repo-token input optional. Default is github.token'.

I don't think any changes are needed to switch from v3 to v4.

SergeGautherie
SergeGautherie reviewed Oct 2, 2023
View reviewed changes
.github/workflows/labeler.yml
Comment on lines 10 to 11
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it still work with the following removal?

Suggested change
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it won't cause any issue

@sarthakroy2002 sarthakroy2002 closed this by deleting the head repository Oct 20, 2023
ReactOS PRs automation moved this from New PRs to Done Oct 20, 2023
@binarymaster binarymaster added the incomplete PRs that were closed without a real reason (check out later) label Oct 20, 2023
@maj113 maj113 mentioned this pull request Oct 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeGautherie SergeGautherie SergeGautherie left review comments

Assignees
No one assigned
Labels
enhancement For PRs with an enhancement/new feature. incomplete PRs that were closed without a real reason (check out later)
Projects
ReactOS PRs
  
Done
Milestone
No milestone
4 participants
@sarthakroy2002 @SergeGautherie @binarymaster @GeoB99