Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETSHELL] Property page needs to call ReleaseWriteLock #5881

Merged
merged 1 commit into from Nov 4, 2023
Merged

[NETSHELL] Property page needs to call ReleaseWriteLock #5881

merged 1 commit into from Nov 4, 2023

Conversation

whindsaks
Copy link
Contributor

The property page does not release the lock it takes, this prevents other threads from taking the lock later.

JIRA issue: CORE-18349

Related issues

  • If you open the property page from the connections folder and the tray icon at the same time, only the first dialog gets the lock. To solve this, it would have to try to find the existing dialog and just set focus to it if found. Need to investigate how Windows handles this.
  • INetCfgImpl leaks the mutex handle?

@github-actions github-actions bot added the shell All PR's related to the shell (and shell extensions) label Nov 4, 2023
@binarymaster binarymaster added the bugfix For bugfix PRs. label Nov 4, 2023
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation Nov 4, 2023
ReactOS PRs automation moved this from New PRs to Approved by reviewers Nov 4, 2023
@JoachimHenze JoachimHenze merged commit a6c8382 into reactos:master Nov 4, 2023
37 checks passed
ReactOS PRs automation moved this from Approved by reviewers to Done Nov 4, 2023
@whindsaks whindsaks deleted the netshell_CORE18349 branch November 4, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HBelusca HBelusca HBelusca approved these changes

@katahiromz katahiromz katahiromz approved these changes

@JoachimHenze JoachimHenze JoachimHenze approved these changes

@learn-more learn-more Awaiting requested review from learn-more learn-more is a code owner

Assignees
No one assigned
Labels
bugfix For bugfix PRs. shell All PR's related to the shell (and shell extensions)
Projects
ReactOS PRs
  
Done
Milestone
No milestone
6 participants
@whindsaks @learn-more @HBelusca @katahiromz @JoachimHenze @binarymaster