Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMM32][SDK] Implement GetKeyboardLayoutCP #6068

Merged
merged 8 commits into from Dec 2, 2023

Conversation

katahiromz
Copy link
Contributor

@katahiromz katahiromz commented Nov 30, 2023

Purpose

Implementing missing features...
JIRA issue: CORE-19268

Proposed changes

  • Add IMM32!GetKeyboardLayoutCP function.
  • Add it to <imm32_undoc.h>
  • Delete ImmDisableLegacyIME and ImmSendMessageToActiveDefImeWndW functions (2k3/xp IMM32 doesn't have such functions).
  • Modify imm32.spec.
  • Refer ntdll!RtlDllShutdownInProgress function (that is WinXP+).

TODO

  • Do build.

@katahiromz katahiromz added enhancement For PRs with an enhancement/new feature. input method IME/IMM/CTF/Cicero/CUAS/TSF labels Nov 30, 2023
@katahiromz katahiromz added this to New PRs in ReactOS PRs via automation Nov 30, 2023
return FALSE;
}
/* FIXME: Use proper header */
BOOLEAN WINAPI RtlDllShutdownInProgress(VOID);
Copy link
Contributor

@HBelusca HBelusca Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR #6071.
Also, note that this function is Windows XP+ .

dll/win32/imm32/imm.c Outdated Show resolved Hide resolved
dll/win32/imm32/imm.c Outdated Show resolved Hide resolved
katahiromz and others added 2 commits December 1, 2023 07:05
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
dll/win32/imm32/imm.c Outdated Show resolved Hide resolved
@katahiromz katahiromz merged commit d795021 into reactos:master Dec 2, 2023
37 checks passed
ReactOS PRs automation moved this from New PRs to Done Dec 2, 2023
@katahiromz katahiromz deleted the get-key-cp branch December 2, 2023 22:46
@binarymaster binarymaster removed this from Done in ReactOS PRs Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For PRs with an enhancement/new feature. input method IME/IMM/CTF/Cicero/CUAS/TSF
Projects
None yet
2 participants