Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMM32][SDK][NTUSER] Implement ImmProcessKey for Cicero #6106

Merged
merged 6 commits into from
Dec 3, 2023
Merged

[IMM32][SDK][NTUSER] Implement ImmProcessKey for Cicero #6106

merged 6 commits into from
Dec 3, 2023

Conversation

katahiromz
Copy link
Contributor

@katahiromz katahiromz commented Dec 3, 2023 •
edited
Loading

Purpose

Complete CTF IMM for supporting Text Input Processors (TIPs).
JIRA issue: CORE-19268

Proposed changes

  • Add CtfImeProcessCicHotkey and CtfImeSetActiveContextAlways functions to access CTF IMEs.
  • In ImmProcessKey function, check whether Cicero is started in the current thread.
  • In ImmProcessKey function, call CtfImeProcessCicHotkey if necessary.
  • Modify <CtfImeTable.h>.
  • Add CI_CICERO_STARTED flag to "ntuser.h".
  • Fix Imm32JCloseOpen.

TODO

  • Do build.
  • Do small tests.

@katahiromz katahiromz added enhancement For PRs with an enhancement/new feature. input method IME/IMM/CTF/Cicero/CUAS/TSF labels Dec 3, 2023
@katahiromz katahiromz added this to New PRs in ReactOS PRs via automation Dec 3, 2023
@github-actions github-actions bot added the Win32SS For Win32 subsystem (Win32k, GDI/USER DLLs, etc.) related components PRs. label Dec 3, 2023
@katahiromz katahiromz mentioned this pull request Dec 3, 2023
Closed
@katahiromz katahiromz added the bugfix For bugfix PRs. label Dec 3, 2023
@katahiromz katahiromz merged commit 75cf692 into reactos:master Dec 3, 2023
37 checks passed
ReactOS PRs automation moved this from New PRs to Done Dec 3, 2023
@katahiromz katahiromz deleted the process-key branch December 3, 2023 08:33
@binarymaster binarymaster removed this from Done in ReactOS PRs Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix For bugfix PRs. enhancement For PRs with an enhancement/new feature. input method IME/IMM/CTF/Cicero/CUAS/TSF Win32SS For Win32 subsystem (Win32k, GDI/USER DLLs, etc.) related components PRs.
Projects
None yet
Milestone
No milestone
1 participant
@katahiromz