Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COMCTL32] fix image list reading/writing (version number and mixing algorithm) #619

Closed
wants to merge 1 commit into from
Closed

[COMCTL32] fix image list reading/writing (version number and mixing algorithm) #619

wants to merge 1 commit into from

Conversation

Getequ
Copy link
Contributor

@Getequ Getequ commented Jun 16, 2018

Fix version number in reading/writing image list streams and counting pointers for mixing image & mask while reading. Works perfect on data from *.reg files exported from XP/2003.

This is a part of managing tray icons hiding behaviour.

gonzoMD
gonzoMD requested changes Jun 16, 2018
View reviewed changes
Copy link
Member

@gonzoMD gonzoMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*There are several formatting changes. Please don't mix code and formatting.

*As this is a winesynced file, our special reactos changes should made inside #ifdefs

*Check if this bug also occurs on wine and maybe try to send the fix upstream

@sanchaez sanchaez added the bugfix For bugfix PRs. label Jun 16, 2018
@Getequ Getequ force-pushed the il_read branch 4 times, most recently from b9d36a1 to ca953ad Compare June 18, 2018 15:11
@HBelusca
Copy link
Contributor

Let's first wait until Wine agrees with your patch sent upstream.

@Getequ
Copy link
Contributor Author

Getequ commented Jun 21, 2018 •
edited

Yeah, i was sended a patch to them.

@learn-more learn-more added the 3rd party sync Updating 3rd party components, such as Wine and others label Jun 22, 2018
@Getequ Getequ mentioned this pull request Jul 10, 2018
Closed
@JoachimHenze
Copy link
Contributor

JoachimHenze commented Aug 7, 2018 •
edited

Since no JIRA-ticket is linked, I did some random
experiments with PR619 (after commit1) manually applied on top of 0.4.10-dev-435-gfb5d5ec:
-CORE-14433 persists
-CORE-12377 persists
-CORE-10522 persists
-CORE-14262 persists
-CORE-13273 persists
-CORE-14671 persists (the symptoms changed lately a bit, but this was not caused by PR619)
-I had the impression the network icon in systray indicated network IO by blinking a bit more reliable (but could be only pure imagination also)

@gonzoMD
Copy link
Member

gonzoMD commented Aug 16, 2018

Resend to wine. Your patch is out of the list.

@tkreuzer tkreuzer added this to New PRs in ReactOS PRs via automation Dec 9, 2018
@tkreuzer tkreuzer moved this from New PRs to Changes requested or WIP in ReactOS PRs Dec 16, 2018
Getequ added a commit to Getequ/reactos that referenced this pull request Jan 8, 2019
@Getequ
Second release - merry russian Xmas
6d59809 
PRs:
 - aero snap reactos#1226
 - status bar reactos#991
 - image list reactos#619

New functions
 - advapi32.EventRegisterTransfer (stub)
 - kernel32.CallbackMayRunLong
 - kernel32.GetPhysicallyInstalledSystemMemory
@Extravert-ir Extravert-ir added send upstream The patch needs to be sent upstream (to Wine, for example) and removed 3rd party sync Updating 3rd party components, such as Wine and others labels Jun 7, 2020
@Getequ Getequ closed this Jan 8, 2021
ReactOS PRs automation moved this from WIP / Waiting on contributor to Done Jan 8, 2021
@Getequ Getequ reopened this Dec 11, 2021
ReactOS PRs automation moved this from Done to New PRs Dec 11, 2021
@Getequ Getequ mentioned this pull request Dec 11, 2021
Merged
@GeoB99
Copy link
Member

GeoB99 commented Jan 27, 2022

I'm going to close this since this PR as is been sitting here for quite a long time with not further input. Feel free however to poke me though in case you want to continue working on this.

@GeoB99 GeoB99 closed this Jan 27, 2022
ReactOS PRs automation moved this from New PRs to Done Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzoMD gonzoMD gonzoMD requested changes

Assignees
No one assigned
Labels
bugfix For bugfix PRs. send upstream The patch needs to be sent upstream (to Wine, for example)
Projects
ReactOS PRs
  
Done
Milestone
No milestone
8 participants
@Getequ @HBelusca @JoachimHenze @gonzoMD @GeoB99 @learn-more @Extravert-ir @sanchaez