-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GITHUB] Fix builds by dropping VS2017 and retargeting to VS2022 #6899
Conversation
Decided to keep MSBuild updated too. |
4ee7707
to
cfb8a01
Compare
Issue also described here: ilammy/msvc-dev-cmd#80 |
I'm fine with this, but what about moving VS 2017 to Windows 2019 environment? |
sure but if we also keep VS2022 we would have too many builders/artifacts, plus additional complexity with the excludes (so that Windows-2019 runners don't try to build with VS2022) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contingent upon a fix for the ARM build on VS2022.
Putting this here since it seems to be related to the error that the ARM builder experiences https://jira.reactos.org/browse/CORE-14042 seems like it's just ifndef'd out, do we do that for msvc arm (_M_ARM64) too? |
…ctos#6899) GitHub dropped VS2017 in the windows-latest runner: - actions/runner-images#9701 - ilammy/msvc-dev-cmd#80 Addendum to 0f81f46.
__globallocalestatus is missing on VS2022/ARM64 just like on Clang-cl. Addendum to 861360c. CORE-14042 CORE-18200
30bf936
to
f22704a
Compare
Purpose
Github dropped VS2017 in the windows-latest
and seemingly also in windows-2019 (since clang-cl fails to find the 14.1 toolset and it uses windows-2019)runnersactions/runner-images@4411220 It also looks like 14.2 is getting removed
JIRA issue: N/A
Proposed changes
TODO