Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage by supporting new default loop #87

Merged
merged 2 commits into from
Jul 11, 2021

Conversation

clue
Copy link
Member

@clue clue commented Jul 9, 2021

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$process = new React\ChildProcess\Process($command);
$process->start($loop);

// new (using default loop)
$process = new React\ChildProcess\Process($command);
$process->start();

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#232, reactphp/stream#159, reactphp/dns#182 and reactphp/socket#260
Refs reactphp/http#410

@clue clue added this to the v0.6.3 milestone Jul 9, 2021
@clue
Copy link
Member Author

clue commented Jul 9, 2021

The first commit updates this to the currently unreleased EventLoop, Stream and Socket components to show how the new default loop can be used in this component (the build should be green). The second commit updates this to the releases that have yet to be tagged. This is expected to fail at the moment and should be green once the releases are tagged and the build is restarted.

This is ready for review. I will restart the build and merge once reviewed and the components are tagged.

@clue clue requested a review from WyriHaximus July 10, 2021 19:41
@clue clue changed the title [WIP] Simplify usage by supporting new default loop Simplify usage by supporting new default loop Jul 11, 2021
@clue
Copy link
Member Author

clue commented Jul 11, 2021

Restarted build and everyhing's green now that reactphp/event-loop v1.2.0, reactphp/stream v1.2.0 and reactphp/socket v1.8.0 have been released :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants