Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes I/O dependency at StreamSelectLoopTest to fix Mac OS X tests #161

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Removes I/O dependency at StreamSelectLoopTest to fix Mac OS X tests #161

merged 1 commit into from
Apr 24, 2018

Conversation

nawarian
Copy link
Contributor

@nawarian nawarian commented Apr 9, 2018 •
edited
Loading

@nawarian nawarian mentioned this pull request Apr 9, 2018
Closed
@WyriHaximus WyriHaximus added this to the v0.5.2 milestone Apr 9, 2018
@clue clue changed the title Removes I/O dependency at StreamSelectLoopTest Removes I/O dependency at StreamSelectLoopTest to fix Mac OS X tests Apr 24, 2018
clue
clue approved these changes Apr 24, 2018
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for filing this PR! :shipit:

@clue clue added bug and removed help wanted labels Apr 24, 2018
WyriHaximus
WyriHaximus approved these changes Apr 24, 2018
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus merged commit 945205d into reactphp:master Apr 24, 2018
@nawarian nawarian deleted the fix_stream_select_loop_test branch April 24, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
bug easy pick maintenance
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nawarian @jsor @WyriHaximus @clue