Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test bootstrap by using dev autoloader #169

Merged

Conversation

lcobucci
Copy link
Contributor

This is already being done in other repos of the organisation, let's make it more consistent then =)

This is already being done in other repos of the organisation, let's
make it more consistent then =)
@lcobucci
Copy link
Contributor Author

These failures seem like flaky tests...

Copy link
Member

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that PHPUnit already loads vendor/autoload.php 🙂👍

@clue clue added this to the v0.5.3 milestone Jun 26, 2018
@WyriHaximus WyriHaximus merged commit b2a3488 into reactphp:master Jun 26, 2018
@lcobucci lcobucci deleted the add-dev-namespace-to-autoloader branch June 26, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants