Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test cases due to inaccurate timers #203

Merged
merged 1 commit into from Dec 27, 2019

Conversation

clue
Copy link
Member

@clue clue commented Dec 23, 2019

Builds on top of #202 and others.

@clue clue added this to the v1.1.1 milestone Dec 23, 2019
@clue clue force-pushed the timers-are-inaccurate branch 2 times, most recently from 51f0e69 to 6577e3b Compare Dec 23, 2019
Copy link
Member

@WyriHaximus WyriHaximus left a comment

🎉 , kicked it a dozen times or so and it only failed once so this is a huge improvement 👍

jsor
jsor approved these changes Dec 27, 2019
@jsor jsor merged commit e2e59de into reactphp:master Dec 27, 2019
1 check passed
@clue clue deleted the timers-are-inaccurate branch Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants