Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test cases due to inaccurate timers #203

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Fix failing test cases due to inaccurate timers #203

merged 1 commit into from
Dec 27, 2019

Conversation

clue
Copy link
Member

@clue clue commented Dec 23, 2019

Builds on top of #202 and others.

@clue clue added this to the v1.1.1 milestone Dec 23, 2019
@clue clue force-pushed the timers-are-inaccurate branch 2 times, most recently from 51f0e69 to 6577e3b Compare December 23, 2019 15:13
@clue clue mentioned this pull request Dec 23, 2019
Closed
@clue clue mentioned this pull request Dec 23, 2019
Merged
WyriHaximus
WyriHaximus approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 , kicked it a dozen times or so and it only failed once so this is a huge improvement 👍

@jsor jsor merged commit e2e59de into reactphp:master Dec 27, 2019
@clue clue deleted the timers-are-inaccurate branch December 27, 2019 18:59
@clue clue mentioned this pull request Jul 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clue @jsor @WyriHaximus