-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor documentation improvements for references to deprecated Factory
#241
Conversation
no problems, stumbled over it when somebody changed what we do in php-http/react-adapter i accepted your changes and fixed a spelling error i noticed. |
Thx for the update 👍. The only thing I have to note is that I don't think it's necessary to have three commits for these changes, maybe you could squash these three together? |
of course. just squashed the commits |
Looks good, nice work 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbu Thank you for spotting and filing this PR, the suggested changes look good to me! 👍
The same text is also used in the referenced classes (also note the maximum line length). May I ask you to amend your changes to keep this in sync?
the readme should not recommend to use the factory anymore but Loop::create Co-authored-by: Simon Frings <simon.frings1@web.de>
i adjusted the phpdoc accordingly and made the lines shorter. |
Factory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbu Thanks for looking into this, changes LGTM!
the readme should not recommend to use the factory anymore but Loop::create