Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear event semantics #70

Closed
clue opened this issue Nov 1, 2016 · 0 comments · Fixed by #90
Closed

Unclear event semantics #70

clue opened this issue Nov 1, 2016 · 0 comments · Fixed by #90

Comments

@clue
Copy link
Member

clue commented Nov 1, 2016

The Response is a ReadableStreamInterface, however it does not currently obey its event semantics:

  • It will never emit a close event
  • It will emit an end event if the underlying stream closes
  • It will emit an end event with an error if the underlying stream ends

We should obey the stream semantics here, see also reactphp/stream#59.

Note that this will result in a BC break, so we should target the v0.5.0 release here. Even the examples (#69) highlight how the end event should actually be a close event instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant