Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sane way to close() pending request #36

Closed
clue opened this issue Sep 3, 2015 · 1 comment · Fixed by #91
Closed

Add sane way to close() pending request #36

clue opened this issue Sep 3, 2015 · 1 comment · Fixed by #91
Assignees
@clue
Labels
new feature
Milestone
v0.5.0

Comments

@clue
Copy link
Member

clue commented Sep 3, 2015

Currently, calling close() on a pending Request stream does not necessarily close all underlying resources.

Also, it should probably cancel a pending connection attempt, so this likely depends on reactphp-legacy/socket-client#40
This was referenced Sep 3, 2015
Closed
Closed
@clue clue self-assigned this Mar 10, 2017
@clue
Copy link
Member Author

clue commented Mar 10, 2017

Calling close() should stop connecting / sending as expected and then close the stream, see also #70 for more details about improper event handling.

This is something I'll look into shortly :shipit:

@clue clue added this to the v0.5.0 milestone Mar 20, 2017
@clue clue mentioned this issue May 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clue clue

Labels
new feature
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Request::close() now cancels pending connection attempt clue-labs/http-client
1 participant
@clue