Fix merging default headers if overwritten with custom case headers #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Jun 26, 2017
jsor
approved these changes
Jun 26, 2017
|
Rebased now that #100 is in |
|
FYI Travis builds are acting up, I'm monitoring them. |
|
For the reference: This now works very much similar to the old version of react/http, prior to applying PSR-7: reactphp/http#107 Accordingly, this code will be simplified once work on #41 takes off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Clientalways tried to add aHostheader, unless an explicitHostheader value is already given. This change makes sure that explicit headers are matched case insensitive, so that ahostheader will also be taken into account and will be preserved as-is, without adding a duplicateHostheader as well.Refs #100