LimitHandlers Middleware #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
reviewed
Sep 11, 2017
| $body->expects($this->once())->method('pause'); | ||
| $body->expects($this->once())->method('resume'); | ||
| $limitHandlers = new LimitHandlers(1); | ||
| $limitHandlers(new ServerRequest('GET', 'https://example.com/', [], $body), function () {}); |
There was a problem hiding this comment.
[] -> array() for our old friend PHP 5.3
If find the
|
|
|
|
@jsor what do you think about: |
|
@WyriHaximus That might work, yes. Maybe @clue has some more ideas. |
This was referenced Sep 12, 2017
|
Removed the mile stone because we hit a few roadblocks implementing this properly. Leaving this open for the time until we find a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LimitHandlers Middleware split off from #213
Assumes to be used with #215
Is blocked by #216 for the readme (will create merge conflicts otherwise)
Not sure about name,
LimitConcurrentHandlersmight be a better name, thoughts?