Add max size to request header parser #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2017
WyriHaximus
requested changes
Oct 15, 2017
tests/RequestHeaderParserTest.php
Outdated
| $this->assertInstanceOf('OverflowException', $error); | ||
| $this->assertSame('Maximum header size of ' . $newCustomBufferSize . ' exceeded.', $error->getMessage()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Indenting seems off here, otherwise LGTM 👍
jsor
approved these changes
Oct 15, 2017
clue
reviewed
Nov 8, 2017
| { | ||
| if (!is_integer($maxSize)) { | ||
| throw new \InvalidArgumentException('Invalid type for maxSize provided. Expected an integer value.'); | ||
| } |
There was a problem hiding this comment.
Not sure how much value this check provides? I would vote to remove this and replace this with a docblock (which can be replaced by PHP 7+ typehints eventually).
There was a problem hiding this comment.
@clue how do we want to continue here?
|
Moved this to |
|
@WyriHaximus waiting for @clue's feedback to continue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split-off from #217 in order to solve #214. This PR adds a customisable maximum request-header size.