Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass $next handler to final request handler #308

Merged
merged 1 commit into from Mar 13, 2018

Conversation

clue
Copy link
Member

@clue clue commented Mar 13, 2018

The last handler in a "handler array" is in fact a "final handler" and by definition not a "middleware handler". As such, all but the last entry should receive a $next handler. This is in line with how a "normal request handler" also doesn't receive a $next handler.

Builds on top of the work done by @jsor in #300.
Supersedes / closes #300

@clue clue added this to the v0.8.2 milestone Mar 13, 2018
@WyriHaximus WyriHaximus merged commit 4a80825 into reactphp:master Mar 13, 2018
@clue clue deleted the final-next branch March 13, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants