Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all() to assume null values if no event data is passed #13

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Fix all() to assume null values if no event data is passed #13

merged 1 commit into from
Dec 22, 2017

Conversation

clue
Copy link
Member

@clue clue commented Dec 22, 2017

Resolves / closes #10

@clue clue added the bug label Dec 22, 2017
@clue clue added this to the v1.2.0 milestone Dec 22, 2017
@WyriHaximus WyriHaximus self-requested a review December 22, 2017 11:03
@WyriHaximus WyriHaximus merged commit 3bc2c27 into reactphp:master Dec 22, 2017
@clue clue deleted the all-args branch December 22, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

all() function fails when a specified event doesn't pass any data
3 participants
@clue @jsor @WyriHaximus