Improve first() promise resolution to clean up any garbage references
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd not triggering garbage collection cycles
SimonFrings
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Hey @lucasnetau, thanks for opening this up, always happy about contributions 👍
First up I want to say that I really like your pull request, it's not common that PRs have a quality like this, keep it up!
I executed the new tests you added locally without your fix and can confirm that they'll fail.
Nothing to add here, nice job 👍
Similar things done in reactphp/async#13, see for reference.
WyriHaximus
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Thank you for filing this, and all the other related PR's @lucasnetau 👍
clue
changed the title
first() promise resolution to clean up any garbage references
clue
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
@lucasnetau Thank you for looking into this and filing this high-quality PR! Changes LGTM, keep it up! 
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve memory usage by removing listener reference on stream close and not triggering garbage collection cycles. This was found while debugging a large number of garbage collection cycles coming out of reactphp-child-process-pool.