Merge pull request #163 from clue-labs/2x-php7.4

Run tests on PHP 7.4 (backport to v2.x) and update PHPUnit test setup

.travis.yml

@@ -6,6 +6,9 @@ php:
   - 5.6
   - 7.0
   - 7.1
+  - 7.2
+  - 7.3
+  - 7.4
   - nightly # ignore errors, see below
   - hhvm # ignore errors, see below
 

composer.json

@@ -9,7 +9,7 @@
         "php": ">=5.4.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "~4.8"
+        "phpunit/phpunit": "^7.0 || ^6.5 || ^5.7 || ^4.8.36"
     },
     "autoload": {
         "psr-4": {
@@ -19,7 +19,7 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "React\\Promise\\": "tests/fixtures"
+            "React\\Promise\\": ["tests", "tests/fixtures"]
         }
     },
     "keywords": [

phpunit.xml.dist

@@ -8,8 +8,7 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
-         bootstrap="tests/bootstrap.php"
+         bootstrap="vendor/autoload.php"
 >
     <testsuites>
         <testsuite name="Promise Test Suite">

tests/DeferredTest.php

@@ -44,6 +44,8 @@ public function progressIsAnAliasForNotify()
     public function shouldRejectWithoutCreatingGarbageCyclesIfCancellerRejectsWithException()
     {
         gc_collect_cycles();
+        gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on
+
         $deferred = new Deferred(function ($resolve, $reject) {
             $reject(new \Exception('foo'));
         });
@@ -57,6 +59,8 @@ public function shouldRejectWithoutCreatingGarbageCyclesIfCancellerRejectsWithEx
     public function shouldRejectWithoutCreatingGarbageCyclesIfParentCancellerRejectsWithException()
     {
         gc_collect_cycles();
+        gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on
+
         $deferred = new Deferred(function ($resolve, $reject) {
             $reject(new \Exception('foo'));
         });

tests/FulfilledPromiseTest.php

@@ -52,6 +52,8 @@ public function shouldThrowExceptionIfConstructedWithAPromise()
     public function shouldNotLeaveGarbageCyclesWhenRemovingLastReferenceToFulfilledPromiseWithAlwaysFollowers()
     {
         gc_collect_cycles();
+        gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on
+
         $promise = new FulfilledPromise(1);
         $promise->always(function () {
             throw new \RuntimeException();

tests/PromiseTest.php

@@ -52,6 +52,8 @@ public function shouldRejectIfResolverThrowsException()
     public function shouldResolveWithoutCreatingGarbageCyclesIfResolverResolvesWithException()
     {
         gc_collect_cycles();
+        gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on
+
         $promise = new Promise(function ($resolve) {
             $resolve(new \Exception('foo'));
         });

tests/TestCase.php

@@ -2,7 +2,7 @@
 
 namespace React\Promise;
 
-class TestCase extends \PHPUnit_Framework_TestCase
+class TestCase extends \PHPUnit\Framework\TestCase
 {
     public function expectCallableExactly($amount)
     {
@@ -36,8 +36,23 @@ public function expectCallableNever()
 
     public function createCallableMock()
     {
-        return $this
-            ->getMockBuilder('React\\Promise\Stub\CallableStub')
-            ->getMock();
+        return $this->getMockBuilder('stdClass')->setMethods(array('__invoke'))->getMock();
+    }
+
+    public function setExpectedException($exception, $exceptionMessage = '', $exceptionCode = null)
+    {
+        if (method_exists($this, 'expectException')) {
+            // PHPUnit 5+
+            $this->expectException($exception);
+            if ($exceptionMessage !== '') {
+                $this->expectExceptionMessage($exceptionMessage);
+            }
+            if ($exceptionCode !== null) {
+                $this->expectExceptionCode($exceptionCode);
+            }
+        } else {
+            // legacy PHPUnit 4
+            parent::setExpectedException($exception, $exceptionMessage, $exceptionCode);
+        }
     }
 }