Merge cfc6bca into c00edcc

reactphp · Apr 29, 2016 · f16fe82 · f16fe82
2 parents c00edcc + cfc6bca
commit f16fe82
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 8 deletions.
diff --git a/src/Promise.php b/src/Promise.php
@@ -13,6 +13,8 @@ class Promise implements ExtendedPromiseInterface, CancellablePromiseInterface
     private $requiredCancelRequests = 0;
     private $cancelRequests = 0;
 
+    private $nextHandlerId = '0';
+
     public function __construct(callable $resolver, callable $canceller = null)
     {
         $this->canceller = $canceller;
@@ -25,13 +27,26 @@ public function then(callable $onFulfilled = null, callable $onRejected = null,
             return $this->result()->then($onFulfilled, $onRejected, $onProgress);
         }
 
+        $handlerId = $this->nextHandlerId;
+        $cleanUpFn = function () use ($handlerId) {
+            if (isset($this->handlers[$handlerId])) {
+                unset($this->handlers[$handlerId]);
+            }
+            if (isset($this->progressHandlers[$handlerId])) {
+                unset($this->progressHandlers[$handlerId]);
+            }
+        };
+        $this->nextHandlerId++;
+
         if (null === $this->canceller) {
-            return new static($this->resolver($onFulfilled, $onRejected, $onProgress));
+            return new static($this->resolver($handlerId, $onFulfilled, $onRejected, $onProgress), $cleanUpFn);
         }
 
         $this->requiredCancelRequests++;
 
-        return new static($this->resolver($onFulfilled, $onRejected, $onProgress), function () {
+        return new static($this->resolver($handlerId, $onFulfilled, $onRejected, $onProgress), function () use ($cleanUpFn) {
+            $cleanUpFn();
+
             if (++$this->cancelRequests < $this->requiredCancelRequests) {
                 return;
             }
@@ -46,14 +61,16 @@ public function done(callable $onFulfilled = null, callable $onRejected = null,
             return $this->result()->done($onFulfilled, $onRejected, $onProgress);
         }
 
-        $this->handlers[] = function (ExtendedPromiseInterface $promise) use ($onFulfilled, $onRejected) {
+        $this->handlers[$this->nextHandlerId] = function (ExtendedPromiseInterface $promise) use ($onFulfilled, $onRejected) {
             $promise
                 ->done($onFulfilled, $onRejected);
         };
 
         if ($onProgress) {
-            $this->progressHandlers[] = $onProgress;
+            $this->progressHandlers[$this->nextHandlerId] = $onProgress;
         }
+
+        $this->nextHandlerId++;
     }
 
     public function otherwise(callable $onRejected)
@@ -97,9 +114,9 @@ public function cancel()
         $this->call($canceller);
     }
 
-    private function resolver(callable $onFulfilled = null, callable $onRejected = null, callable $onProgress = null)
+    private function resolver($handlerId, callable $onFulfilled = null, callable $onRejected = null, callable $onProgress = null)
     {
-        return function ($resolve, $reject, $notify) use ($onFulfilled, $onRejected, $onProgress) {
+        return function ($resolve, $reject, $notify) use ($handlerId, $onFulfilled, $onRejected, $onProgress) {
             if ($onProgress) {
                 $progressHandler = function ($update) use ($notify, $onProgress) {
                     try {
@@ -114,13 +131,13 @@ private function resolver(callable $onFulfilled = null, callable $onRejected = n
                 $progressHandler = $notify;
             }
 
-            $this->handlers[] = function (ExtendedPromiseInterface $promise) use ($onFulfilled, $onRejected, $resolve, $reject, $progressHandler) {
+            $this->handlers[$handlerId] = function (ExtendedPromiseInterface $promise) use ($onFulfilled, $onRejected, $resolve, $reject, $progressHandler) {
                 $promise
                     ->then($onFulfilled, $onRejected)
                     ->done($resolve, $reject, $progressHandler);
             };
 
-            $this->progressHandlers[] = $progressHandler;
+            $this->progressHandlers[$handlerId] = $progressHandler;
         };
     }
 

diff --git a/tests/CancellationMemLeakTest.php b/tests/CancellationMemLeakTest.php
@@ -0,0 +1,20 @@
+<?php
+namespace React\Promise;
+
+class CancellationMemLeakTest extends TestCase
+{
+    public function testCancelCleansUp()
+    {
+        $mainDeferred = new Deferred;
+
+        $memoryUsage = memory_get_usage();
+
+        for ($i = 0; $i < 100000; $i++) {
+            $innerDeferred = new Deferred;
+            race([$mainDeferred->promise()->then(), $innerDeferred->promise()]);
+            $innerDeferred->resolve();
+        }
+
+        $this->assertLessThan(2 * $memoryUsage, memory_get_usage());
+    }
+}