Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 Deprecation Notice #181

Closed
SerafimArts opened this issue Jan 7, 2021 · 1 comment
Closed

PHP 8.0 Deprecation Notice #181

SerafimArts opened this issue Jan 7, 2021 · 1 comment
Labels
bug new feature
Milestone
v3.0.0

Comments

@SerafimArts
Copy link

This error is currently being reproduced on PHP 8.0:

react/promise: dev-master:

Method ReflectionParameter::getClass() is deprecated in ...\react\promise\src\functions.php on line 345

Similar behavior on latest react/promise: 2.8 version.
@SerafimArts SerafimArts changed the title PHP 8.0 support PHP 8.0 Deprecation Notice Jan 7, 2021
@clue
Copy link
Member

clue commented Jan 7, 2021

@SerafimArts Thanks for reporting, can confirm this raises a deprecation notice when using the otherwise() method, but does otherwise work just fine. This is being work on in #176, we'll work this out as soon as time allows 👍

I'm closing this for now as progress is already being tracked, please feel free to come back if you have more details and we can always reopen this 👍

@clue clue closed this as completed Jan 7, 2021
@clue clue added this to the v3.0.0 milestone Nov 17, 2021
@clue clue mentioned this issue Nov 17, 2021
Closed
@amir-khoshbakht amir-khoshbakht mentioned this issue Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug new feature
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@clue @SerafimArts