Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with PHP 8 #192

Closed
amir-khoshbakht opened this issue Jul 24, 2021 · 3 comments
Closed

Problem with PHP 8 #192

amir-khoshbakht opened this issue Jul 24, 2021 · 3 comments

Comments

@amir-khoshbakht
Copy link

amir-khoshbakht commented Jul 24, 2021

The "otherwise" method on Promise seems to have a problem with PHP8
it will throw this exception :

#message: "Method ReflectionParameter::getClass() is deprecated"
#code: 0
#file: "./vendor/react/promise/src/functions.php"
#line: 346
#severity: E_DEPRECATED

it seems the problem is caused by :
\React\Promise\Promise - Line : 77
\React\Promise - functions.php - Line : 346

if (!$expectedException->getClass()) {

update:

This method is deprecated in the current version of PHP (8) :
Reference

This notice can be turned off using native php error_reporting() function.
Reference

run time error reporting setting :
error_reporting(error_reporting() & ~E_DEPRECATED);

@clue
Copy link
Member

clue commented Nov 17, 2021

@my-random-username Thank you for reporting!

This has been addressed with #198 that will be released as part of the v2.9.0 release.

Duplicate of #181

@clue clue closed this as completed Nov 17, 2021
@SwenVanZanten
Copy link

@my-random-username Thank you for reporting!

This has been addressed with #198 that will be released as part of the v2.9.0 release.

Duplicate of #181

When can we expect v2.9.0?

@SimonFrings
Copy link
Member

Hey @SwenVanZanten, this won't take long, our plan is to get this out in the next few days 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants