Test PHP 7.4 on Travis #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on (`vendor/bin/phpunit --coverage-text`).
This was referenced Mar 4, 2020
WyriHaximus
approved these changes
Mar 4, 2020
jsor
approved these changes
Mar 5, 2020
Closed
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #157, thanks @WyriHaximus for the original version and helping tracking this down with @CharlotteDunois. This changeset builds on top of this, but instead of skipping affected tests will make sure tests pass by clearing any garbage references twice before running any of the affected assertions.
I still wonder if this could potentially be an upstream bug in
ext-xdebugor PHP itself, but I don't see any guarantees thatgc_collect_cycles()collects all cycles, so perhaps we were just lucky in previous versions. I consider this minimal changeset to be good enough until we find a better solution in the future