Support iterable
type for all()
+ race()
+ any()
#225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for the
iterable
type forall()
+race()
+any()
. Instead of only accepting anarray
, each function now also accepts instances implementingTraversable
such asIterator
andGenerator
instances.This is a pure feature addition that does not break BC. With these changes applied, our API is also pretty much identical to ES6 promises commonly used in JavaScript.
The first commit highlights how this is essentially only a new type definition and a call to
iterator_to_array()
. The second commit then takes advantage of a more iterative approach that uses less memory and also supports consuming infinite iterators if the resulting promise settles. The test suite confirms this has 100% code coverage.Resolves #221
Builds on top of #149, #35, #83, #219 and others