Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gist link about promise in README.md #250

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix gist link about promise in README.md #250

merged 1 commit into from
Aug 28, 2023

Conversation

SQKo
Copy link
Contributor

@SQKo SQKo commented Aug 27, 2023

The link is no longer valid somehow so i looked up web archive to find the actual gist page

@WyriHaximus WyriHaximus added this to the v3.1.0 milestone Aug 27, 2023
WyriHaximus
WyriHaximus approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change, thanks for catching and PRing this 👍

clue
clue approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SQKo Thanks for taking the time to update this, LGTM! :shipit:

SimonFrings
SimonFrings approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimonFrings SimonFrings merged commit baf9ab5 into reactphp:3.x Aug 28, 2023
13 checks passed
@SQKo SQKo deleted the patch-1 branch October 1, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SQKo @WyriHaximus @clue @SimonFrings