1.1 release for 2.0 compatibility #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| namespace React\Promise; | ||
|
|
||
| if (function_exists('React\Promise\resolve')) { | ||
| return; |
There was a problem hiding this comment.
IIRC PHP only supports conditional definitions if they are actually wrapped in conditionals? In other words, has this very statement been tested? :)
|
Awesome, I'd love to get this in! 👍 This certainly helps migrating from legacy PHP versions and the v1 Promise API.
Personally, I'd vote to postpone this for now, so we can get this out quicker. Should we actually need these in the future, we can still push them with an eventual v1.2 release. Other than my above remark, this LGTM 👍 |
This was referenced Jun 30, 2015
|
👍 on postponing the optional todos |
jsor
changed the title
|
+1 |
|
👍 Let's get this in! :) |
|
This is hugely helpful, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could become a 1.1 release which makes the API more compatible with 2.0 while preserving full backward compatibility. With this release, consuming packages can require both 1.0 (with PHP 5.3 support) and 2.0.
Changes:
Optional todos: