Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger an E_USER_ERROR instead of throwing an exception from done() #97

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Trigger an E_USER_ERROR instead of throwing an exception from done() #97

merged 1 commit into from
Sep 19, 2017

Commits on Aug 25, 2017

  1. Trigger an E_USER_ERROR instead of throwing an exception from done() 

    If an error (either a thrown exception or returned rejection) escapes the
done() callbacks, it will now cause a fatal error by using trigger_error() with
E_USER_ERROR instead of (re)throwing.

Because promise resolution is synchronous, those exceptions bubbled up to the
reject() call which mixed resolution and consumption parts.
    @jsor
    jsor committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    23cd28c View commit details
    Browse the repository at this point in the history