You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Connector::create() currently creates a Stream instance with no access to the remote address. When connecting to hostnames instead of IP addresses the target remote address is particularly useful.
Instead, it should return a React\Stream\Connection instance with implements the ConnectionInterface in order to provide a getRemoteAddress() method.
While this change is quite simple, it has a couple of drawbacks:
Is it accepted practice to create additional dependencies between react's sub-packages?
Connection currently uses stream_socket_recvfrom() which bypasses stream wrappers (in particular SSL streams won't be decrypted anymore). Maybe this should be handled in a separate ticket anyway? (Also considering Alternate Scheme Support for Client bergie/dnode-php#24 here...)
The text was updated successfully, but these errors were encountered:
Connector::create()
currently creates aStream
instance with no access to the remote address. When connecting to hostnames instead of IP addresses the target remote address is particularly useful.Instead, it should return a
React\Stream\Connection
instance with implements theConnectionInterface
in order to provide agetRemoteAddress()
method.While this change is quite simple, it has a couple of drawbacks:
Connection
currently usesstream_socket_recvfrom()
which bypasses stream wrappers (in particular SSL streams won't be decrypted anymore). Maybe this should be handled in a separate ticket anyway? (Also considering Alternate Scheme Support for Client bergie/dnode-php#24 here...)The text was updated successfully, but these errors were encountered: