Added support for /etc/hosts #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function query($nameserver, Query $query) | ||
| { | ||
| $that = $this; |
There was a problem hiding this comment.
master is now 5.4+, so this stuff can go
There was a problem hiding this comment.
this is great news :)
|
+1 for one-time process of /etc/hosts |
|
This PR seems like a good starting point, thanks @arnaud-lb! This PR has been WIP for quite some time now and things have changed considerably since then :-) React now consists of individual components that are maintained individually. Supporting the hosts file is now related to the react/dns component. Somebody has already filed reactphp/dns#10 to keep track of this, so I suppose it makes sense to focus our hosts file related efforts on this component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for /etc/hosts through a HostsFileExecutor executor.
The Factory is changed so that the Resolver looks in /etc/hosts first. The executor stack looks like this: CachedExecutor -> HostsFileExecutor -> RetryExecutor -> Executor.