Include timeout logic to avoid dependency on reactphp/promise-timer #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the build error on legacy PHP 5.4 on Windows is unrelated to this changeset, see #306 for workaround. We can either proceed with applying this PR with a known build error or merge the other PR first and rebase this one, either works for me 👍 |
That error just blows my mind. But approved and merged it. |
WyriHaximus
approved these changes
Jun 7, 2023
SimonFrings
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds timeout logic to avoid the otherwise unneeded dependency on reactphp/promise-timer. There are plans to deprecate the reactphp/promise-stream package as discussed in https://github.com/orgs/reactphp/discussions/475 and in either case I'd like to remove additional dependencies where possible.
In particular, reactphp/socket appears to be the only ReactPHP packages that still depends on reactphp/promise-timer at the moment. This means that once this PR is merged, most consumers of this package would no longer install reactphp/promise-timer by default. Perhaps most notably, this means that IDE autocompletion for
resolve()andreject()would now only suggest the correctReact\Promise\resolve()andReact\Promise\reject()functions instead of the rarely useful and deprecated ones (see reactphp/promise-timer#51).This changeset does not otherwise affect our public API, so this should be safe to apply. The test suite confirms this has 100% code coverage and does not otherwise affect our APIs.
Note that this changeset does not preclude the discussion in https://github.com/orgs/reactphp/discussions/475, so whether or not or when the package will be deprecated is still up for debate. If you want to explicitly install this dependency, you can still install it like this:
Builds on top of reactphp/dns#213 and others
See also reactphp/http#482 for similar changes to remove reactphp/promise-stream from reactphp/http