Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native types to public API #178

Merged
merged 1 commit into from
May 19, 2024
Merged

Add native types to public API #178

merged 1 commit into from
May 19, 2024

Conversation

clue
Copy link
Member

@clue clue commented May 17, 2024

This changeset adds native types to the public API as discussed in #173.

Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types.

Builds on top of #177, #175 and reactphp/cache#60

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@WyriHaximus WyriHaximus merged commit cf107f5 into reactphp:3.x May 19, 2024
9 checks passed
@clue clue deleted the types branch May 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants