Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove BufferedSink #45
This ticket aims to serve as a discussion basis whether this class should actually be part of this repository.
Bridging between Stream-land and Promise-land is arguably out of scope for basic streams. Also, this happens to be the only class that has an "optional dependency" on promises. Full promise support would also involve proper cancellation support, stricter promise version checks and much more…
As an alternative, I would suggest making https://github.com/clue/php-promise-stream-react an official react repo and redirect there.
referenced this pull request
Aug 15, 2016
Agreed, mainly wanted to point out that I think it is a bad plan to remove this without official replacement