Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/monorepo #43

Closed
wants to merge 4 commits into from
Closed

Features/monorepo #43

wants to merge 4 commits into from

Conversation

Angra974
Copy link

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #29
Fixes #39
Fixes #42
Fixes #41
Fixes #40
Fixes #38

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using it currently with my build based on vitejs

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • can be use like the original react-play
  • create a play.cy.ts file in cypress/e2e folder ( the file is rewritten if a play is created again ).
  • add '-plays="path_to_play"' to specify the folder where the plays are located to install in this folder ( here "path_to_play")
  • create a index.json file at the side of index.js but not used in reactplay
  • add '-i="something_here" to download image from plays with http link, correct plays cover extension, create webp version and minimal version of image ( I use them in a picture tag to accelerate the application )

The index.json file

I use it to load only one play in playMeta.jsx instead of all the play as it is currently in react play.
Can be use to navigate from one play to another, cool while need to navigate through all of them to test your changes.
In playlist.jsx, no need to import all the plays as this json file have the minimum data for the current process.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant