Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Feature request]: In filter modal creator dropdown should be a card list with image #102

Closed
koustov opened this issue Apr 24, 2022 · 8 comments · Fixed by #483
Closed

✨ [Feature request]: In filter modal creator dropdown should be a card list with image #102

koustov opened this issue Apr 24, 2022 · 8 comments · Fixed by #483
Assignees
@Sachin-chaurasiya

Comments

@koustov
Copy link
Member

koustov commented Apr 24, 2022

Is your feature request related to a problem? Please describe.
Currently, the creator dropdown is a flat list. It doesn't give enough context of the GitHub profile

Describe the solution you'd like
Use a contact card drop-down instead

Describe alternatives you've considered
NA

Additional context
NA
@atapas atapas added the good first issue New-contributor friendly label Apr 26, 2022
@Sachin-chaurasiya
Copy link
Member

@atapas @koustov , I would like to work on this issue.

@atapas
Copy link
Member

atapas commented May 21, 2022

@Sachin-chaurasiya Assigned. Let's discuss the design approach for this one first. Please open a discussion thread.

@atapas atapas removed the good first issue New-contributor friendly label May 21, 2022
@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Assigned. Let's discuss the design approach for this one first. Please open a discussion thread.

@atapas , Sure will do that.

@Sachin-chaurasiya
Copy link
Member

@atapas , Opened one discussion thread here #213

@atapas
Copy link
Member

atapas commented Aug 2, 2022

Hey @Sachin-chaurasiya

Are you on it?

@Sachin-chaurasiya
Copy link
Member

Hey @Sachin-chaurasiya

Are you on it?

Hey @atapas , Didn't get a chance to look further.

@atapas
Copy link
Member

atapas commented Aug 2, 2022

Hey @Sachin-chaurasiya
Are you on it?

Hey @atapas , Didn't get a chance to look further.

Will you work on it in the near future?

@Sachin-chaurasiya
Copy link
Member

Hey @Sachin-chaurasiya
Are you on it?

Hey @atapas , Didn't get a chance to look further.

Will you work on it in the near future?

Yes @atapas , I will start working on it this weekend.

Sachin-chaurasiya added a commit to Sachin-chaurasiya/react-play that referenced this issue Aug 6, 2022
@Sachin-chaurasiya
✨ [Feature] reactplay#102: In filter modal creator dropdown should b…
a1d33ff 
…e a card list with image
@Sachin-chaurasiya Sachin-chaurasiya mentioned this issue Aug 6, 2022
Closed
8 tasks
Sachin-chaurasiya added a commit that referenced this issue Aug 12, 2022
@Sachin-chaurasiya
✨ [Feature] #102: In filter modal creator dropdown should be a card l…
f8350f3 
…ist with image
@Sachin-chaurasiya Sachin-chaurasiya mentioned this issue Aug 12, 2022
Merged
8 tasks
atapas added a commit that referenced this issue Aug 15, 2022
@atapas
Merge pull request #483 from reactplay/creator-dropdown
ca890fe 
✨ [Feature] #102: In filter modal creator dropdown should be a card list with image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@atapas @koustov @Sachin-chaurasiya