Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve portability to vitejs or other bundler by cleaning the code #1249

Closed
Angra974 opened this issue Sep 23, 2023 · 1 comment · Fixed by #1250
Closed

Improve portability to vitejs or other bundler by cleaning the code #1249

Angra974 opened this issue Sep 23, 2023 · 1 comment · Fixed by #1250
Assignees

Comments

@Angra974
Copy link
Contributor

Angra974 commented Sep 23, 2023

react-play is build with cra.
CRA implementation make it works in the certain way that can't be often handle by another builder.
Some steps can be taken to be able to use the application with CRA and other bundler to make the process more smooth.

For exemple,
we import "index.css" directly in index.jsx file but the correct way is to import it relatively with "./index.css".
It didn't set a warning with CRA as it is an expected behavior but the code is not clean and make migration more difficult.

Here will be an attemps to smooth this transition by adding some little change without breaking the actual code.

image

image

image

image

image

image

image

@Angra974 Angra974 self-assigned this Sep 23, 2023
@github-actions
Copy link

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant