-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up file path and import #1250
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for reactplayio failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. there could be another ticket for the eventPartners and eventProviders to move them into constant file rather than putting in the component itself.
Description
When using the application with Vite, each time some files need to be modified to get it started without looking about the
difference of parameters/configuration.
We can easily avoid this by cleaning the code and let the developer mind what he want to implement.
Fixes #1249
Type of change
And relative path where the where not used ( App.jsx and index.jsx )
Clean relative path where the where used by was not efficient because CRA accepts them but not other bundlers.
Add jsx extensions to a play ( react-transition )
Clean up bad import
Please delete options that are not relevant.
How Has This Been Tested?
With CRA and Vite.
Checklist:
Screenshots or example output
see #1249 for screenshots of problems.