Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: create-play not working with lower node versions #46

Closed
murtuzaalisurti opened this issue Apr 18, 2022 · 1 comment · Fixed by #72
Closed

🐛 [Bug report]: create-play not working with lower node versions #46

murtuzaalisurti opened this issue Apr 18, 2022 · 1 comment · Fixed by #72
Assignees
Labels
bug Something isn't working

Comments

@murtuzaalisurti
Copy link
Member

Describe the bug
In lower node versions (< 16), there is an issue with creating a new play by running yarn create-play or npm run create-play. The script works fine with node version 16.14.0.

To Reproduce
Steps to reproduce the behavior:

  1. Using nvm try to use a node version lower than 16 (probably 14) and run npm run create-play or yarn create-play.
  2. Fill necessary details.
  3. An error might be evident stating trim(...).replaceAll() is not a function!

Expected behavior
To create a play

Screenshots
Code_jzJJI3SB2p

Desktop (please complete the following information):

  • OS: [e.g. Windows 10]
@murtuzaalisurti murtuzaalisurti added the bug Something isn't working label Apr 18, 2022
@murtuzaalisurti murtuzaalisurti changed the title 🐛 [Bug report]: 🐛 [Bug report]: create-play not working with lower node versions Apr 18, 2022
@6km
Copy link
Member

6km commented Apr 19, 2022

Node.js v14 has V8 8.4 but replaceAll was added to V8 8.5 (which is used by node.js v15).
This means that you can't use .replaceAll if your Node.js version is lower that 15.

Can you reproduce this with node.js v15?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants