Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added React Todo Application #100

Merged
merged 6 commits into from
Apr 25, 2022
Merged

Added React Todo Application #100

merged 6 commits into from
Apr 25, 2022

Conversation

nirban256
Copy link
Contributor

@nirban256 nirban256 commented Apr 24, 2022

Description: Added a React Todo Application which keeps track of daily todos that need to be done.

Fixes # (issue) : 91

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Apr 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/EbQLckCE769pmdoMyRcpY3r1R1ea
✅ Preview: https://react-play-git-fork-nirban256-main-atapas.vercel.app

@nirban256
Copy link
Contributor Author

@atapas review it Sir

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirban256 mostly looks good. Please take care of the review comments to get it merged asap.

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/react-todo-app/ReactTodoApp.jsx Outdated Show resolved Hide resolved
src/plays/react-todo-app/ReactTodoApp.jsx Outdated Show resolved Hide resolved
src/plays/react-todo-app/components/Input.jsx Outdated Show resolved Hide resolved
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirban256 A few more comments about the styling.

src/plays/react-todo-app/react-todo.css Outdated Show resolved Hide resolved
src/plays/react-todo-app/react-todo.css Outdated Show resolved Hide resolved
src/plays/react-todo-app/react-todo.css Show resolved Hide resolved
@6km
Copy link
Member

6km commented Apr 25, 2022

I suggest not adding a todo if the input has no value.

@atapas
Copy link
Member

atapas commented Apr 25, 2022

I suggest not adding a todo if the input has no value.

Yes I have provided that comment too.

@nirban256
Copy link
Contributor Author

@atapas I have removed the local Storage functionality as it was not working and made the other changes, but couldn't change the page level scroll

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirban256 A few more cosmetic changes.

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/react-todo-app/ReactTodoApp.jsx Outdated Show resolved Hide resolved
src/plays/react-todo-app/react-todo.css Outdated Show resolved Hide resolved
src/plays/react-todo-app/react-todo.css Outdated Show resolved Hide resolved
src/plays/react-todo-app/react-todo.css Outdated Show resolved Hide resolved
@nirban256
Copy link
Contributor Author

made the changes @atapas Sir

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more comment I gave and

DO NOT COMMIT the yarn.lock file as there are no changes in the package.json file.

src/plays/react-todo-app/react-todo.css Outdated Show resolved Hide resolved
@nirban256
Copy link
Contributor Author

I added the yarn.lock in the gitignore file and made the change. Is it correct now? @atapas

@atapas
Copy link
Member

atapas commented Apr 25, 2022

I added the yarn.lock in the gitignore file and made the change. Is it correct now? @atapas

Yes that's right.. add it in .gitignore but also do not push your yarn lock file...

@nirban256
Copy link
Contributor Author

nirban256 commented Apr 25, 2022

@atapas Can you tell me how can I not push the yarn.lock file?

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirban256 looks good.

@atapas
Copy link
Member

atapas commented Apr 25, 2022

@atapas Can you tell me how can I not push the yarn.lock file?

I shall remove it in a different PR

@atapas atapas merged commit 433f6e9 into reactplay:main Apr 25, 2022
@atapas atapas linked an issue Apr 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Todo List App
3 participants