Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2PlaysAMonth]: Pixy - Pixel Art Creator #1023

Merged
merged 16 commits into from
Mar 22, 2023
Merged

[#2PlaysAMonth]: Pixy - Pixel Art Creator #1023

merged 16 commits into from
Mar 22, 2023

Conversation

raibove
Copy link
Contributor

@raibove raibove commented Feb 28, 2023

Description

This tool allows users to create Pixel art by placing colored squares on a grid and saving them as a jpg image.

Fixes #965 (issue)

How Has This Been Tested?

Manually tested.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

pixy_react_play

@vercel
Copy link

vercel bot commented Feb 28, 2023

@raibove is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@koustov koustov added the #2PlaysAMonth #2PlaysAMonth Event label Mar 3, 2023
@vercel
Copy link

vercel bot commented Mar 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 12, 2023 at 4:03AM (UTC)

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Use cover.png instead of cover.jpg
  2. Please record a demo video on stackstream
    Rest looks good

@atapas
Copy link
Member

atapas commented Mar 8, 2023

Visit Preview

Hey @raibove this is so close to done. I want to merge it. Please take care asap/

@raibove
Copy link
Contributor Author

raibove commented Mar 8, 2023

Visit Preview

Hey @raibove this is so close to done. I want to merge it. Please take care asap/

I have updated the cover from jpg to png, but for video I have already added lin in readme, do I need to add it somewhere else too?

@atapas
Copy link
Member

atapas commented Mar 12, 2023

Visit Preview

Hey @raibove this is so close to done. I want to merge it. Please take care asap/

I have updated the cover from jpg to png, but for video I have already added lin in readme, do I need to add it somewhere else too?

You just need to edit your play from localhost(click on the edit button in the play header) and add the link.

@raibove
Copy link
Contributor Author

raibove commented Mar 13, 2023

Visit Preview

Hey @raibove this is so close to done. I want to merge it. Please take care asap/

I have updated the cover from jpg to png, but for video I have already added lin in readme, do I need to add it somewhere else too?

You just need to edit your play from localhost(click on the edit button in the play header) and add the link.

I have edited the play and added video link

@raibove raibove requested a review from koustov March 15, 2023 12:47
@raibove
Copy link
Contributor Author

raibove commented Mar 22, 2023

@atapas Can you check if any changes are required and merge this PR

@atapas atapas merged commit 17213a5 into reactplay:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#2PlaysAMonth #2PlaysAMonth Event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[#2PlaysAMonth]: Pixy
4 participants