Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#1046 Fix #1047

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Issue#1046 Fix #1047

merged 6 commits into from
Mar 8, 2023

Conversation

Abhishek-90
Copy link
Contributor

@Abhishek-90 Abhishek-90 commented Mar 8, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Include changes to fix Issue #1046. Added className to li tag and made corresponding selector changes in css file as well.

Fixes #1046

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code

Screenshots or example output

Screenshot_1

@vercel
Copy link

vercel bot commented Mar 8, 2023

@Abhishek-90 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@Abhishek-90
Copy link
Contributor Author

@atapas @koustov @Sachin-chaurasiya please review the changes

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ❌ Failed (Inspect) Mar 8, 2023 at 8:38AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good to me. Shall merge after the build passes.

@atapas atapas merged commit d2664d2 into reactplay:main Mar 8, 2023
@Abhishek-90 Abhishek-90 deleted the Issue#1046 branch March 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: a tag styling of pink color which is affecting all the list tags in the entire repo
2 participants