Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanding cards #110

Merged
merged 3 commits into from
Apr 29, 2022
Merged

expanding cards #110

merged 3 commits into from
Apr 29, 2022

Conversation

Deepak8717
Copy link
Member

@Deepak8717 Deepak8717 commented Apr 28, 2022

Description

I have added a new project called expanding cards.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

It shows bunch of striped cards on the screen and you just have click to expand it.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 5:04PM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments given. Also please drop a cover.ping file in the play folder. Let me know if you need help in making the cover.

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/expanding-cards/Readme.md Outdated Show resolved Hide resolved
@atapas atapas linked an issue Apr 28, 2022 that may be closed by this pull request
@atapas
Copy link
Member

atapas commented Apr 28, 2022

@Deepak8717 i have created the issue, please update details.

@atapas
Copy link
Member

atapas commented Apr 28, 2022

@Deepak8717 The UI looks very cool.

image

In the responsive mode(smaller screen), could you align the images vertically using media query? Then people will be able to see the demo from phones too.

image

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more

src/plays/expanding-cards/ExpandingCards.css Outdated Show resolved Hide resolved
src/plays/expanding-cards/ExpandingCards.css Outdated Show resolved Hide resolved
src/plays/expanding-cards/Readme.md Outdated Show resolved Hide resolved
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deepak8717 Looks good.

@atapas
Copy link
Member

atapas commented Apr 29, 2022

@Deepak8717

Ideally, once you take care of a review comment, you need to acknowledge that by resolving the discussion. You can do it by clicking a button. I have taken care of it now, in future you can take care.

image

@atapas atapas merged commit c1f33d1 into reactplay:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Expanding Cards
2 participants