Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Img Added in footer #1119

Merged
merged 1 commit into from
May 2, 2023
Merged

Netlify Img Added in footer #1119

merged 1 commit into from
May 2, 2023

Conversation

Saurav-Pant
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 17, 2023

@Saurav-Pant is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ✅ Ready (Inspect) Visit Preview 1 resolved Apr 19, 2023 10:07am

@atapas
Copy link
Member

atapas commented Apr 19, 2023

@Saurav-Pant I can not merge it without an issue number. Please provide it.

@priyankarpal
Copy link
Member

@Saurav-Pant may I offer a suggestion? Adding a descriptive title and a clear description of the issue, along with relevant screenshots if possible & with the issue number would greatly assist the maintainers in understanding and addressing the problem. Thank you for considering this.

@Saurav-Pant
Copy link
Contributor Author

@Saurav-Pant I can not merge it without an issue number. Please provide it.

#1116 is the issue Number

@Saurav-Pant
Copy link
Contributor Author

@Saurav-Pant may I offer a suggestion? Adding a descriptive title and a clear description of the issue, along with relevant screenshots if possible & with the issue number would greatly assist the maintainers in understanding and addressing the problem. Thank you for considering this.

Thanks, I will do it Next Time.

@atapas
Copy link
Member

atapas commented May 2, 2023

@Saurav-Pant may I offer a suggestion? Adding a descriptive title and a clear description of the issue, along with relevant screenshots if possible & with the issue number would greatly assist the maintainers in understanding and addressing the problem. Thank you for considering this.

Yes! We need to talk more about these in our community Catch up call. @priyankarpal You may want to take it up on the next meeting.

@atapas atapas linked an issue May 2, 2023 that may be closed by this pull request
@atapas atapas merged commit fb0a50d into reactplay:main May 2, 2023
@priyankarpal
Copy link
Member

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add new Netlify image
3 participants