Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: random meme generator play was breaking due to broken api url #1145

Merged
merged 3 commits into from
May 14, 2023

Conversation

murtuzaalisurti
Copy link
Member

@murtuzaalisurti murtuzaalisurti commented Apr 30, 2023

Description

Random meme generator play was breaking due to broken API url.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 4:29pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@atapas
Copy link
Member

atapas commented May 2, 2023

@murtuzaalisurti Please create an issue for it and attach.

@murtuzaalisurti
Copy link
Member Author

@atapas yep, sure

@murtuzaalisurti
Copy link
Member Author

fixes #1151

@netlify
Copy link

netlify bot commented May 6, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit a5f5959
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/645e67a8f6a25800090ab80f

@murtuzaalisurti murtuzaalisurti linked an issue May 6, 2023 that may be closed by this pull request
1 task
@murtuzaalisurti
Copy link
Member Author

@atapas linked the issue, you can merge it now!

@murtuzaalisurti
Copy link
Member Author

hi @atapas, cypress tests are failing

@atapas atapas merged commit 3f6baa3 into main May 14, 2023
1 of 6 checks passed
@atapas atapas deleted the fix-meme-generator branch May 14, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: meme generator play not working as expected
3 participants