Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsors Section in Homepage #1181

Merged
merged 17 commits into from
Jun 21, 2023
Merged

Sponsors Section in Homepage #1181

merged 17 commits into from
Jun 21, 2023

Conversation

ammaaraslam
Copy link
Member

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This is build of the sponsors section in the ReactPlay home page which includes Event Sponsors & Partners, Prime Sponsors and Backers.
Fixes #1180

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This has been tested locally.4

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ammaaraslam ammaaraslam requested a review from atapas June 10, 2023 16:34
@ammaaraslam ammaaraslam self-assigned this Jun 10, 2023
@vercel
Copy link

vercel bot commented Jun 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ❌ Failed (Inspect) Jun 21, 2023 4:29am

@netlify
Copy link

netlify bot commented Jun 10, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 819d404
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/64927baa0a21c400086ce34d
😎 Deploy Preview https://deploy-preview-1181--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@ammaaraslam ammaaraslam changed the title Sponsors Sponsors Section in Homepage Jun 10, 2023
@Sachin-chaurasiya
Copy link
Member

@ammaaraslam, the font size of the highlighted section seems to be very big, it would be great if we reduce it.
cc: @atapas
image

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ammaaraslam posted review comments.

Also please fix this(on mobile)

image

src/common/home/Sponsors.jsx Show resolved Hide resolved
src/common/home/Sponsors.jsx Show resolved Hide resolved
src/common/home/Sponsors.jsx Show resolved Hide resolved
atapas
atapas previously approved these changes Jun 21, 2023
@atapas
Copy link
Member

atapas commented Jun 21, 2023

@ammaaraslam, the font size of the highlighted section seems to be very big, it would be great if we reduce it. cc: @atapas image

@ammaaraslam could you please respond to this so that we know it's ready to merge or more work pending?

FYI.. the heading style should be the same as the heading of other sections on the page.

@ammaaraslam
Copy link
Member Author

@ammaaraslam, the font size of the highlighted section seems to be very big, it would be great if we reduce it. cc: @atapas image

@ammaaraslam could you please respond to this so that we know it's ready to merge or more work pending?

FYI.. the heading style should be the same as the heading of other sections on the page.

@atapas all work is done. And in terms of the styling of the heading, it is exactly the same as every other. Only difference, is the underline decoration, because in mobile, the heading spans multiple lines and the usual decoration breaks. So that's why had to change it.

@atapas
Copy link
Member

atapas commented Jun 21, 2023

https://deploy-preview-1181--reactplayio.netlify.app

Thanks for confirming that the size is same.

One difference I find though. All other heading only the highlighted texts are bold but in this case the entire line. I think we can do like:

Our Partners & Sponsors

What I mean is to bold and underline only Partners & Sponsors

Our <u><b>Partners & Sponsors</b></u>

@ammaaraslam

@ammaaraslam
Copy link
Member Author

@atapas

Oh ok. Now I've made the changes, have a look and confirm

@atapas
Copy link
Member

atapas commented Jun 21, 2023

Ready to Merge

@atapas atapas merged commit 45a5824 into main Jun 21, 2023
6 of 8 checks passed
@atapas atapas deleted the sponsors branch June 21, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Sponsors Section in Homepage
3 participants