Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve external link error in localhost #1183 #1184

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Conversation

Angra974
Copy link
Contributor

@Angra974 Angra974 commented Jun 14, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

When we use the application on localhost, the new events button leads us to a local link instead of an external link.
so http://localhost:3000/https://hustles.reactplay.io
instead of https://hustles.reactplay.io

Fixes #1183
Change the used for internal link routing by a link.

Type of change

Minimal. Change to

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No test is needed. Just get the link works as it should.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [ X] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ X] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ❌ Failed (Inspect) Jun 14, 2023 8:26am

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit e08a16f
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6489774a72841600084dab9b
😎 Deploy Preview https://deploy-preview-1184--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@atapas atapas linked an issue Jun 14, 2023 that may be closed by this pull request
1 task
@atapas
Copy link
Member

atapas commented Jun 14, 2023

@Angra974 Fix the lint error plz

image

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@atapas atapas merged commit 3effa65 into main Jun 14, 2023
5 of 6 checks passed
@atapas atapas deleted the Bug_1183_Events_link branch June 14, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Event link doesn't work on localhost
3 participants