Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mooderation Phase-1 #1207

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Mooderation Phase-1 #1207

merged 9 commits into from
Jul 10, 2023

Conversation

yung-coder
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Moderating Testimonials Phase - 1

Fixes #1201

Type of change

  • [✅ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested by me in my local system

Checklist:

  • [✅] I have performed a self-review of my own code
  • [✅] I have commented my code, particularly in hard-to-understand areas
  • [✅] I have made corresponding changes to the documentation
  • [✅] My changes generate no new warnings
  • [✅] I have added tests that prove my fix is effective or that my feature works
  • [✅] New and existing unit tests pass locally with my changes
  • [✅] Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Jul 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 5:34am

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit a13aa97
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/64ab956d330e0d000810be79
😎 Deploy Preview https://deploy-preview-1207--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yung-coder yung-coder self-assigned this Jul 9, 2023
@yung-coder yung-coder requested a review from atapas July 9, 2023 08:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment

src/common/Testimonial/TestimonialModal.jsx Outdated Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented Jul 9, 2023

@yung-coder

Build fails

image

@atapas atapas merged commit 132b2f3 into main Jul 10, 2023
7 of 8 checks passed
@atapas atapas deleted the testimonial-fix branch July 10, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add Testimonial Moderation - Phase 1
2 participants