Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Automate the process to check and fix lint issues #1241

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

supminn
Copy link
Contributor

@supminn supminn commented Sep 9, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added a husky pre-commit setup to test for lint and prettier issues when a new commit is made to this repository.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

Screenshots or example output

The husky pre-commit hook would be called whenever a commit is made to this repo. Note that lint-staged is run to fix linting and prettier issues.
Screenshot 2023-09-09 at 10 19 38 PM

@vercel
Copy link

vercel bot commented Sep 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 9:32am

@netlify
Copy link

netlify bot commented Sep 9, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 5e58cdc
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/650c0c53eecbcc0008b345bd
😎 Deploy Preview https://deploy-preview-1241--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@atapas atapas merged commit 49072ff into main Sep 21, 2023
6 of 7 checks passed
@atapas atapas deleted the supminn-1138/husky branch September 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Automate the process to check and fix lint issues
5 participants