Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clock flicker & color contrast #130

Merged
merged 1 commit into from
May 3, 2022

Conversation

DalpatRathore
Copy link
Contributor

Hi! @atapas I have fixed three things for Clock Play:

  1. Clock flickering by adding width and font-family
  2. Better background and font color contrast.
  3. Responsive design for the small screen.
  • Current Clock
    Clock

  • New Design
    Clock

Please review this contribution.

Thanks

@vercel
Copy link

vercel bot commented May 2, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@vercel
Copy link

vercel bot commented May 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 2, 2022 at 5:32PM (UTC)

@atapas
Copy link
Member

atapas commented May 2, 2022

@DalpatRathore plz create an issue and associate to the PR

@atapas atapas merged commit 5a78163 into reactplay:main May 3, 2022
@DalpatRathore DalpatRathore deleted the clock-improvement branch May 3, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: clock flicker & color contrast
2 participants